Burrow as a library & minor refactoring #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state Burrow was in, I couldn't use it directly as a library. I've seen a lot of projects using burrow as a separate binary and read from another application. This is less than optimal if you need the Lag evaluation bits in an existing Go monitoring tool. This keeps the functionality exactly the same, but moves the files around so that it will still continue to work as expected. The package names have been changed to mine to use it with projects.
|
OK, this has conflicts now based on other PRs. But yes, you need to change everything to not refer to your own fork. Once that's done I can review. |
|
thanks @toddpalino I have reverted the renaming back to linkedin, let me know if anything else needs to be changed. |
- Returns a snapshot of the brokers, consumers as stored by Burrow - the idea is to return a usable value that's usable publicly
|
This is great. I would like this to be merged so I can use Burrow in the telegraf metrics collection library. |
|
Resolved by 1.0 rewrite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state Burrow was in, I couldn't use it directly as a library. I've
seen a lot of projects using burrow as a separate binary and read from
another application. This is less than optimal if you need the Lag
evaluation bits in an existing Go monitoring tool.
This keeps the functionality exactly the same, but moves the files
around so that it will still continue to work as expected.
The package names have been changed to mine to use it with projects.
It should be trivial to change, otherwise I can change, rebase before merge.