Add Basic Auth to HTTP Server #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be refactored for 1.0 now. At present, there's still no auth in the API endpoint |
|
I'm closing this out as it appears abandoned as a PR and it's incompatible with 1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Realminterface is in charge of authenticating a user and getting its Roles. There are 2 implementations at the moment: File based and Anonymous (to get default role) which can be chained. The Realm name is inspired by Tomcat, Elasticsearch...The
UserCheckeris in charge of integrating HTTP Server with Realms.The types names may be changed: suggestions are welcome.
The File Realm uses bcrypt to hash passwords on disk: I can use another hashing library/algorithm.
This pull request is related to PR #184 which brings HTTPS