Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sarama 1.21.0 #512

Merged
merged 2 commits into from Apr 9, 2019
Merged

sarama 1.21.0 #512

merged 2 commits into from Apr 9, 2019

Conversation

vvuibert
Copy link
Contributor

@vvuibert vvuibert commented Apr 1, 2019 •
edited

Release notes: https://github.com/Shopify/sarama/releases/tag/v1.21.0
remove go version 1.10.8 because staticcheck does not support it

@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited

Coverage Status

Coverage remained the same at 74.488% when pulling f65032b on Shopify:sarama-1.21.0 into 3cdc7e7 on linkedin:master.

andrewjamesbrown
andrewjamesbrown approved these changes Apr 2, 2019
View reviewed changes
Copy link

@andrewjamesbrown andrewjamesbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shopify has been running this in production already successfully. 🚢

@bai bai merged commit f7de04f into linkedin:master Apr 9, 2019
@bai bai deleted the sarama-1.21.0 branch April 9, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjamesbrown andrewjamesbrown andrewjamesbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vvuibert @coveralls @andrewjamesbrown @bai