Use system SSL store for notifiers by default #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewchoi5
approved these changes
Dec 16, 2019
|
|
||
| rootCAs, caError := x509.SystemCertPool() | ||
| if caError != nil { | ||
| log.Println("Unable to load system certs, using empty cert pool instead") |
|
I've tested these changes and it fixes @andrewchoi5 can we get this PR merged please |
|
+1 Running into this issue too when updating to the latest for kafka 2.4 support. |
|
This issue is preventing us from upgrading. @andrewchoi5 would be great to have this merged |
Merge permission isn't visible on my end. |
thanks - @bai can you help out with getting this merged & released? |
|
Thanks 💯I'll release this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix to issue #540, using the system store by default (if possible), and adding any extra certificates to that (if applicable).