Continue to support losely specified older Kafka versions #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid breaking existing configurations where users either losely specify a kafka version - like 0.10.2 - we should continue to support that configuration. However, Sarama handles most of the version parsing still, we have some fallbacks ready to support existing configs.
bai
approved these changes
Oct 7, 2021
|
No worries. I think it would be reasonable to drop the wonky version support if there was a new major version for Burrow. But that might be a lot for just this small stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid breaking existing configurations where users either losely
specify a kafka version - like 0.10.2 - we should continue to support
that configuration. However, Sarama handles most of the version parsing
still, we have some fallbacks ready to support existing configs.
Essentially adds back in support for existing configs that was removed in #715