Tweak build flags for internalDup2 on darwin arm64 #743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that prevents building on darwin amr64 (M1 macs):
My understanding is that
open_out_log_unix.go
was designed to be used everywhere exceptwindows
andlinux_arm64
, as evidenced by the comment:However, the build flags in
open_out_log_unix.go
were also excludingdarwin_arm64
, which was not provided (rightly so) byopen_out_log_linux_arm64.go
.I decided to go the route of making the build flags of
open_out_log_unix.go
only excludelinux_arm64
instead of adding mentions of darwin, because I felt it was more semantic; a better representation of the inherent non-overlapping union of the 3 flags:windows
linux_arm64
!windows && !linux_arm64
(not the first 2)