Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors TransformationJob to handle terminal states in a more determisitic fashion #273

Conversation

vamshi-dhulipala
Copy link
Contributor

@vamshi-dhulipala vamshi-dhulipala commented Apr 10, 2024

  1. Updated release API in TransformationJob such that it only takes care of stopping transcoders and releasing muxers without having to deal with callbacks. Exceptions that can be ignored here are now handled & logged to ensure that the execution continues.
  2. Separated out logic that updates stats (with latest target format) and deletes output files (in error scenarios) into individual methods.
  3. Updated overall terminal state (cancelled/completed/failed) handling logic to follow a deterministic order of updating stats, stopping & releasing transcoders, deleting output files, and invoking appropriate callbacks.

Testing Done:

  1. Updated unit tests
  2. Manual testing to make sure existing functionality did not break and all app callbacks are invoked appropriately

@vamshi-dhulipala vamshi-dhulipala marked this pull request as ready for review April 17, 2024 21:21
@vamshi-dhulipala vamshi-dhulipala marked this pull request as draft April 17, 2024 21:22
@vamshi-dhulipala vamshi-dhulipala marked this pull request as ready for review April 17, 2024 21:23
@izzytwosheds izzytwosheds merged commit fe754dd into linkedin:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants