Preventing retentionTime and retentionCount to be set to 0 #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2790 +/- ##
============================================
+ Coverage 64.24% 70.22% +5.98%
- Complexity 10398 11678 +1280
============================================
Files 840 840
Lines 71755 71920 +165
Branches 8611 8647 +36
============================================
+ Hits 46099 50509 +4410
+ Misses 23004 18775 -4229
+ Partials 2652 2636 -16 ☔ View full report in Codecov by Sentry. |
SophieGuo410
force-pushed
the
Branch_do_not_allow_0
branch
2 times, most recently
from
df3f8e0
to
ca2c50a
Compare
SophieGuo410
force-pushed
the
Branch_do_not_allow_0
branch
from
ca2c50a
to
42ed2a2
Compare
SophieGuo410
changed the title
justinlin-linkedin
approved these changes
May 22, 2024
Comment on lines
598
to
601
| if (ttlFromHeader == 0) { | ||
| throw new RestServiceException(Headers.TTL + "[" + ttlFromHeader + "] should not be 0", | ||
| RestServiceErrorCode.InvalidArgs); | ||
| } |
There was a problem hiding this comment.
we probably don't need this one here.
There was a problem hiding this comment.
Remove this part and updated to add test and filter out null(default) after serialization as we discussed.
SophieGuo410
force-pushed
the
Branch_do_not_allow_0
branch
from
9df34a8
to
687b83c
Compare
SophieGuo410
force-pushed
the
Branch_do_not_allow_0
branch
from
687b83c
to
31edd19
Compare
justinlin-linkedin
approved these changes
May 23, 2024
| field.setAccessible(true); | ||
| Object value = field.get(dataset); | ||
| if (value != null) { | ||
| gen.writeObjectField(field.getName(), value); |
There was a problem hiding this comment.
we should probably use annotation value here. something like
gen.writeObjectField(field.getAnnotation(JsonProperty.class).value(), value);
There was a problem hiding this comment.
Sure, updated it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.