Commenting out misbehaving tests #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commenting out tests that were found to fail intermittently or hang on OSX and Linux
| @@ -1034,13 +1034,13 @@ public void simpleOneDCFourNodeOneDiskTwoPartition() | |||
| simple(getClusterMapOneDCFourNodeOneDiskTwoPartition()); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
could we create github issues to fix them?
There was a problem hiding this comment.
We discussed that and decided to keep them in our internal backlog ticket, since we have not started creating github issues.
There was a problem hiding this comment.
We have to create it as an issue. The project is already open source.
There was a problem hiding this comment.
We can, it is just that this is going to be a one off thing then, there are several more important issues that we should probably move first?
There was a problem hiding this comment.
We should but we should avoid accumulating more debt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting out tests that were found to fail intermittently or hang on OSX and Linux.
Time to review: 2 min.
Reviewers: @pnarayanan, @xiahome