Allow for ByteBufferInputStream to return underlying ByteBuffer #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to avoid a copy if the ByteBufferInpustStream consumer needs to get the contents into a ByteBuffer.
This was referenced May 20, 2016
| stream4.getByteBuffer()); | ||
| byteBuf.rewind(); | ||
| ByteBufferInputStream stream5 = new ByteBufferInputStream(byteBuf.duplicate()); | ||
| ByteBufferInputStream stream6 = new ByteBufferInputStream(stream5, 1024); |
There was a problem hiding this comment.
minor: Can you do byteBuf.remaining() instead of 1024?
There was a problem hiding this comment.
Was just going with the pattern in the rest of this class. Also, I think the hardcoded value makes sense here as that is the source of truth. Using byteBuf.remaining() might mask issues or catch them later (like if byteBuf was not rewound).
|
LGTM |
|
Made another simple required change that might as well go as part of this patch. Please take a look. |
|
LGTM |
|
Merging as per @pnarayanan's comment. @xiahome Please take a look |
|
@pnarayanan Retained your second commit message since it is useful. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to avoid a copy if the
ByteBufferInputStreamconsumer needs to get the contents into aByteBuffer. In particular, this will help avoid a copy when the router needs to convert theByteBufferInputStreamreturned byMessageFormatinto aByteBuffer. Rather than read from this stream into an allocatedByteBuffer, the underlyingByteBuffercan be directly used once this patch goes in.Ming, Gopal. ~10 minutes.
Built and tested on Linux and OS X, and formatted.