New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PutBlobOptions in router API #983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow request options to be passed into the Router::putBlob method. In contrast to the BlobProperties, which are persisted with the blob in storage, PutBlobOptions only influence the router logic. For now, the options object is empty, but will soon include some options required for data chunk upload.
cgtz
force-pushed
the
router-put-blob-options
branch
from
June 29, 2018 17:25
4d9ecb3
to
b826097
Compare
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
============================================
+ Coverage 67.82% 67.87% +0.04%
- Complexity 4537 4541 +4
============================================
Files 372 374 +2
Lines 29300 29305 +5
Branches 3709 3709
============================================
+ Hits 19873 19891 +18
+ Misses 8392 8381 -11
+ Partials 1035 1033 -2
Continue to review full report at Codecov.
|
vgkholla
approved these changes
Jun 29, 2018
pnarayanan
approved these changes
Jun 29, 2018
cgtz
added a commit
to cgtz/ambry
that referenced
this pull request
Jul 20, 2018
This will allow request options to be passed into the Router::putBlob method. In contrast to the BlobProperties, which are persisted with the blob in storage, PutBlobOptions only influence the router logic. For now, the options object is empty, but will soon include some options required for data chunk upload.
cgtz
added a commit
to cgtz/ambry
that referenced
this pull request
Jul 23, 2018
This will allow request options to be passed into the Router::putBlob method. In contrast to the BlobProperties, which are persisted with the blob in storage, PutBlobOptions only influence the router logic. For now, the options object is empty, but will soon include some options required for data chunk upload.
cgtz
added a commit
to cgtz/ambry
that referenced
this pull request
Jul 23, 2018
This will allow request options to be passed into the Router::putBlob method. In contrast to the BlobProperties, which are persisted with the blob in storage, PutBlobOptions only influence the router logic. For now, the options object is empty, but will soon include some options required for data chunk upload.
cgtz
added a commit
to cgtz/ambry
that referenced
this pull request
Jul 23, 2018
This will allow request options to be passed into the Router::putBlob method. In contrast to the BlobProperties, which are persisted with the blob in storage, PutBlobOptions only influence the router logic. For now, the options object is empty, but will soon include some options required for data chunk upload.
cgtz
added a commit
to cgtz/ambry
that referenced
this pull request
Jul 24, 2018
This will allow request options to be passed into the Router::putBlob method. In contrast to the BlobProperties, which are persisted with the blob in storage, PutBlobOptions only influence the router logic. For now, the options object is empty, but will soon include some options required for data chunk upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.
For now, the options object is empty, but will soon include some options
required for data chunk upload.