Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PutBlobOptions in router API #983

Merged
merged 2 commits into from Jun 29, 2018

Conversation

cgtz
Copy link
Contributor

@cgtz cgtz commented Jun 29, 2018

This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.

@cgtz cgtz requested review from pnarayanan and vgkholla June 29, 2018 17:23
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.
@codecov-io
Copy link

Codecov Report

Merging #983 into master will increase coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #983      +/-   ##
============================================
+ Coverage     67.82%   67.87%   +0.04%     
- Complexity     4537     4541       +4     
============================================
  Files           372      374       +2     
  Lines         29300    29305       +5     
  Branches       3709     3709              
============================================
+ Hits          19873    19891      +18     
+ Misses         8392     8381      -11     
+ Partials       1035     1033       -2
Impacted Files Coverage Δ Complexity Δ
.../java/com.github.ambry/router/RouterErrorCode.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...ava/com.github.ambry.router/NonBlockingRouter.java 82.24% <ø> (ø) 40 <0> (ø) ⬇️
...github.ambry.frontend/AmbryBlobStorageService.java 92.71% <ø> (ø) 39 <0> (ø) ⬇️
...ava/com.github.ambry.frontend/PostBlobHandler.java 92.5% <ø> (ø) 5 <0> (ø) ⬇️
...a/com.github.ambry/tools/perf/rest/PerfRouter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/com.github.ambry/router/CallbackUtils.java 66.66% <ø> (ø) 1 <0> (ø) ⬇️
....github.ambry/tools/admin/ConcurrencyTestTool.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/com.github.ambry/router/PutBlobOptions.java 100% <100%> (ø) 2 <2> (?)
...ava/com.github.ambry.frontend/FrontendMetrics.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...com.github.ambry/router/PutBlobOptionsBuilder.java 100% <100%> (ø) 2 <2> (?)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdf479...b826097. Read the comment docs.

@pnarayanan pnarayanan merged commit dd162b2 into linkedin:master Jun 29, 2018
cgtz added a commit to cgtz/ambry that referenced this pull request Jul 20, 2018
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.
cgtz added a commit to cgtz/ambry that referenced this pull request Jul 23, 2018
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.
cgtz added a commit to cgtz/ambry that referenced this pull request Jul 23, 2018
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.
cgtz added a commit to cgtz/ambry that referenced this pull request Jul 23, 2018
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.
cgtz added a commit to cgtz/ambry that referenced this pull request Jul 24, 2018
This will allow request options to be passed into the Router::putBlob
method. In contrast to the BlobProperties, which are persisted with
the blob in storage, PutBlobOptions only influence the router logic.

For now, the options object is empty, but will soon include some options
required for data chunk upload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants