Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let fast-avro align with vanilla avro to handle unknown enum value #191

Open
gaojieliu opened this issue Aug 31, 2021 · 0 comments
Open
Labels
bug Something isn't working fastavro issues related to avro-fastserde

Comments

@gaojieliu
Copy link
Collaborator

Right now, Fast-Avro would fail fast during fast-class generation when encountering an unknown enum value, which is different from the vanilla Avro, which would fail the de-serialization when encountering an unknown enum value at de-serialization time.
Avro Enum default value is only supported in Avro-1.9+, so having such kind of alignment could help users, who are still using older Avro versions.

nisargthakkar pushed a commit to linkedin/venice that referenced this issue Sep 1, 2021
…avro dependency

The latest fast-avro release addressed an issue to align with Vanilla
Avro to return mutable empty map when the map doesn't contain any element
during de-serialiazation.

Related fast-avro issue:
linkedin/avro-util#191

RB=2797142
BUG=VENG-8138
G=voldemort-reviewers
R=sdwu,mnhuang
A=mnhuang
@gaojieliu gaojieliu reopened this Sep 1, 2021
@radai-rosenblatt radai-rosenblatt added bug Something isn't working fastavro issues related to avro-fastserde labels Oct 1, 2021
yuzheng21 added a commit to yuzheng21/avro-util that referenced this issue Oct 6, 2021
yuzheng21 added a commit to yuzheng21/avro-util that referenced this issue Oct 6, 2021
gaojieliu pushed a commit that referenced this issue Oct 7, 2021
#221)

* fail at runtime for unknown enums, to behave consistently with vanilla avro (#191)

* code gen
flowenol pushed a commit to RTBHOUSE/avro-util that referenced this issue Aug 23, 2023
linkedin#221)

* fail at runtime for unknown enums, to behave consistently with vanilla avro (linkedin#191)

* code gen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fastavro issues related to avro-fastserde
Projects
None yet
Development

No branches or pull requests

2 participants