Fixed two bugs in FastDeserializerGenerator #46
Conversation
volauvent
force-pushed
the
fix-fast-deserializer-generator
branch
from
7dbd483
to
7ba8013
Compare
| @@ -698,7 +700,8 @@ private void processMap(JVar mapSchemaVar, final String name, final Schema mapSc | |||
|
|
|||
| if (action.getShouldRead()) { | |||
| Symbol valuesActionSymbol = null; | |||
| for (Symbol symbol : action.getSymbol().production) { | |||
| for (int i = action.getSymbol().production.length - 1; i >= 0; --i) { | |||
There was a problem hiding this comment.
Could you explain more about this change?
Why sequence matters in this situation?
There was a problem hiding this comment.
It's for nested Map deserializer generation. The "symbol.production" generated by ResolvingGrammarGenerator is in reversed order, and the REPEATER symbol holds the sequence of the symbols that forms the production for it.
Resolving grammar of nested Map is like:
- symbol/"map-end"/"REPEATER" ---- 1st layer Map
- production
- symbol/"map-end"/"REPEATER" ---- 1st layer Map
- symbol/"map-end"/"REPEATER" ---- 2nd layer Map
- symbol/"map-start"/"TERMINAL" ---- 2nd layer Map
- symbol/"map-start"/"TERMINAL" ---- 1st layer Map
The fastDeserializer generator tries to proceed as a depth-first, left-to-right traversal of the schema. So when it is processing the 2nd layer of Map (production of 1st layer Map Symbol), we need to iterate production list in reverse order to get the correct 2nd layer "map-end" symbol.
There was a problem hiding this comment.
needs at least some comment in the code :-)
There was a problem hiding this comment.
Agreed and good catch!
This logic seems tricky, and You can put your explanation as the javadoc for this section.
There was a problem hiding this comment.
Done. Added comments for the change.
1. fixed null exception when updating actual exceptions for already generated record method; 2. corrected value action symbols iteration order for nested Map;
volauvent
force-pushed
the
fix-fast-deserializer-generator
branch
from
fa1c757
to
c69eeb6
Compare
Fixed two bugs which caused FastDeserializer generation failure -
@gaojieliu @FelixGV @radai-rosenblatt @pravk03