Xcode 9.2 #219
Merged
Xcode 9.2 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that's it ? @ob |
|
lol, yeah... but apparently circleCI doesn't support Xcode 9.2 yet? It doesn't trigger a build... |
oliverhu
approved these changes
Dec 5, 2017
| @@ -85,7 +85,6 @@ bluepill_build_sample_app() | |||
| -workspace Bluepill.xcworkspace \ | |||
| -scheme BPSampleApp \ | |||
| -sdk iphonesimulator \ | |||
| -destination 'platform=iOS Simulator,name=iPhone 7,OS=11.1' \ | |||
There was a problem hiding this comment.
It's unnecessary. When building the app, if the destination doesn't exit (for example because you upgraded Xcode and there is no 11.1 iOS runtime) the build fails.
There was a problem hiding this comment.
You mean exist instead of exit ? :)
|
Note we shouldn't merge this until CircleCI supports Xcode 9.2 to get tests working. |
Closed
|
@ob does CircleCI support xcode 9.2 now? how can one check? |
|
Yeah, they do (at least according to this. |
|
Guys, are you going to merge this? just main.m small conflict resolution is needed) |
|
Yeah, thanks for the reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off the
Xcode-9.1branch so #207 needs to go in first.