Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current metrics reporter does not work with Kafka 2.6.0 #1309

Closed
tomncooper opened this issue Aug 10, 2020 · 1 comment
Closed

Current metrics reporter does not work with Kafka 2.6.0 #1309

tomncooper opened this issue Aug 10, 2020 · 1 comment
Assignees
@tomncooper
Labels
correctness A condition affecting the proper functionality.

Comments

@tomncooper
Copy link
Contributor

The current CruiseControlMetricsReporter does not work on Kafka 2.6.0 clusters. The issue seems to be linked to recent changes in Kafka that changed where the MetricsRegistry is obtained from. The default registry now needs to be pulled from the kafka.metrics.KafkaYammerMetrics class instead of the com.yammer.metrics.Metrics class.

I have a working fix but I was wondering if I should open a PR against the migrate_to_kafka_2_5 branch or wether it would be better for a committer to create a migrate_to_kafka_2_6 branch that I can open it against?
@tomncooper tomncooper changed the title Current metrics reporter does not work with Kafka 2.6+ Current metrics reporter does not work with Kafka 2.6.0 Aug 10, 2020
@efeg
Copy link
Collaborator

efeg commented Aug 10, 2020

@tomncooper Thanks for bringing this up and experimenting with a fix.
This would seem to require a new branch -- I created migrate_to_kafka_2_6 for you to create the PR against.

@efeg efeg added the correctness A condition affecting the proper functionality. label Aug 10, 2020
@tomncooper tomncooper mentioned this issue Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomncooper tomncooper

Labels
correctness A condition affecting the proper functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@efeg @tomncooper