Add support for Kafka 2.6 brokers #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switched to Kafka 2.6.0 library versions * Changed class used for obtaining the default metrics registry in the metrics reporter Signed-off-by: Thomas Cooper <tom.n.cooper@gmail.com>
This was required to allow the ExecutionTask class to be compiled by scala without raising cyclical reference errors. Signed-off-by: Thomas Cooper <tom.n.cooper@gmail.com>
efeg
reviewed
Aug 11, 2020
...main/java/com/linkedin/kafka/cruisecontrol/metricsreporter/CruiseControlMetricsReporter.java
Outdated
Show resolved
Hide resolved
...main/java/com/linkedin/kafka/cruisecontrol/metricsreporter/CruiseControlMetricsReporter.java
Outdated
Show resolved
Hide resolved
...main/java/com/linkedin/kafka/cruisecontrol/metricsreporter/CruiseControlMetricsReporter.java
Outdated
Show resolved
Hide resolved
...main/java/com/linkedin/kafka/cruisecontrol/metricsreporter/CruiseControlMetricsReporter.java
Outdated
Show resolved
Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/executor/ExecutionTask.java
Outdated
Show resolved
Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/executor/ExecutionTaskState.java
Outdated
Show resolved
Hide resolved
amuraru
reviewed
Aug 12, 2020
...main/java/com/linkedin/kafka/cruisecontrol/metricsreporter/CruiseControlMetricsReporter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Cooper <tom.n.cooper@gmail.com>
tomncooper
changed the base branch from
migrate_to_kafka_2_6
to
migrate_to_kafka_2_5
efeg
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1309 and allows the Cruise Control Metrics reporter to work with Kafka 2.6 brokers.
This PR also refactors the
ExecutionTask.Stateenum into its own separate class. This is needed as switching to the Kafka 2.6 libraries causes the gradle scala compiler to throw cyclical reference errors for this class.