Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensors to report the number of slow brokers #1463

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

efeg
Copy link
Collaborator

@efeg efeg commented Jan 26, 2021

This PR resolves #1210.

  1. Adds the following sensors:
DESCRIPTION MBEAN NAME
The number of brokers that are metric anomaly suspects, pending more evidence to conclude either way kafka.cruisecontrol:name=AnomalyDetector.num-suspect-metric-anomalies
The number of brokers that have recently been identified with a metric anomaly kafka.cruisecontrol:name=AnomalyDetector.num-recent-metric-anomalies
The number of brokers that continue to be identified with a metric anomaly for a prolonged period kafka.cruisecontrol:name=AnomalyDetector.num-persistent-metric-anomalies
  1. (Trivial) Make sensor constant names public to enable access to them from outside the class.

@efeg efeg requested review from Lincong and zornhsu January 26, 2021 03:58
Copy link
Contributor

@Lincong Lincong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@efeg efeg merged commit 6ec68dd into linkedin:master Jan 26, 2021
@efeg efeg deleted the feat/slowBrokerSensor branch January 26, 2021 21:05
efeg added a commit to efeg/cruise-control that referenced this pull request Jan 26, 2021
efeg added a commit to efeg/cruise-control that referenced this pull request Jan 26, 2021
zornhsu pushed a commit to zornhsu/cruise-control that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new sensor to expose number of slow broker detected
2 participants