Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from ZK to Kafka Admin Client #1569

Merged
merged 10 commits into from
Jul 15, 2021
Merged

Switch from ZK to Kafka Admin Client #1569

merged 10 commits into from
Jul 15, 2021

Commits on Jul 3, 2021

  1. Created TopicConfigProvider using Kafka Admin Client 

    Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    64fa381 View commit details
    Browse the repository at this point in the history

  2. Addressed reviewer comments 

    * Changed ZK based provider to use old class name and gave new Kafka Admin provider new name
* Added deprecated annotation to old ZK provider and additional javadoc
  explaining the deprecation.
* Switched to using the configured admin client timeout from the main config class
* Fixed Copy Right date
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    596b60f View commit details
    Browse the repository at this point in the history

  3. Moved JSON config loading method for TopicConfigProviders to abstract… 

    … parent class

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    fde2168 View commit details
    Browse the repository at this point in the history

  4. Switched KafkaAdminTopicConfigProvider to use provided Admin Client i… 

    …nstance from LoadMonitor

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    d7d093b View commit details
    Browse the repository at this point in the history

  5. Reduced ERROR level logging in KafkaAdminTopicConfigProvider 

    Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    0bcc1f3 View commit details
    Browse the repository at this point in the history

  6. Switch from using .all() to .values() for alltopics config fetching i… 

    …n the KafkaAdminTopicConfigProvider

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    4b26a60 View commit details
    Browse the repository at this point in the history

  7. Added deprecated javadoc to ZK based topic config provider and moved … 

    …common config key to abstract parent class

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    9705e01 View commit details
    Browse the repository at this point in the history

  8. Simplified the future processing in the all topic configs method of K… 

    …afka Admin Topic Config Provider

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    bf009b3 View commit details
    Browse the repository at this point in the history

  9. Added new method to TopicConfigProvider and refactored implementations 

    Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    4e45b49 View commit details
    Browse the repository at this point in the history

  10. Addressed reviewer comments 

    Signed-off-by: Thomas Cooper <code@tomcooper.dev>
    @tomncooper
    tomncooper committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    4cbfd8f View commit details
    Browse the repository at this point in the history