Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup ProvisionerState for rightsizing clusters #1646

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Setup ProvisionerState for rightsizing clusters #1646

merged 5 commits into from
Aug 13, 2021

Conversation

kaitlynp1206
Copy link
Contributor

This PR resolves #1645.

Created a provisioner state object to track changes for rightsizing a cluster.
Added a test endpoint Rightsize to perform integration testing on the provisioner.

@efeg efeg requested review from lmr3796 and efeg August 7, 2021 00:59
@efeg efeg linked an issue Aug 7, 2021 that may be closed by this pull request
Create a ProvisionerState for rightsizing results #1645
Closed
efeg
efeg reviewed Aug 7, 2021
View reviewed changes
Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaitlynp1206 Thanks for the PR!
Left some comments.

cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerState.java Outdated Show resolved Hide resolved
...in/java/com/linkedin/kafka/cruisecontrol/config/constants/CruiseControlParametersConfig.java Outdated Show resolved Hide resolved
.../main/java/com/linkedin/kafka/cruisecontrol/config/constants/CruiseControlRequestConfig.java Outdated Show resolved Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/Provisioner.java Outdated Show resolved Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerState.java Outdated Show resolved Hide resolved
...ontrol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/parameters/ParameterUtils.java Outdated Show resolved Hide resolved
...control/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/RightsizeResult.java Outdated Show resolved Hide resolved
...control/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/RightsizeResult.java Outdated Show resolved Hide resolved
...control/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/RightsizeResult.java Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Show resolved Hide resolved
@kaitlynp1206 kaitlynp1206 force-pushed the increase_partition_count branch 4 times, most recently from 70e6364 to d0a4836 Compare August 11, 2021 06:28
efeg
efeg requested changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Left more comments.

-- Also please note that there are test failures (I'd recommend making sure all tests pass before submitting your updates -- i.e. a submitted PR should have already been tested for existing and new unit tests. (please see https://github.com/linkedin/cruise-control/blob/master/CONTRIBUTING.md)):

com.linkedin.kafka.cruisecontrol.servlet.parameters.RequestParameterTest > checkOpenApiSpec FAILED
    java.lang.IllegalArgumentException: Schema Parser does not support HTTP methods other than GET/POST
        at com.linkedin.kafka.cruisecontrol.servlet.parameters.RequestParameterTest.parseEndpoint(RequestParameterTest.java:82)
        at com.linkedin.kafka.cruisecontrol.servlet.parameters.RequestParameterTest.parseSchema(RequestParameterTest.java:101)
        at com.linkedin.kafka.cruisecontrol.servlet.parameters.RequestParameterTest.checkOpenApiSpec(RequestParameterTest.java:59)

com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest > checkOpenAPISpec FAILED
    java.lang.NullPointerException
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.checkSchema(ResponseTest.java:139)
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.lambda$checkSchema$2(ResponseTest.java:180)
        at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.checkSchema(ResponseTest.java:156)
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.lambda$checkOperation$0(ResponseTest.java:111)
        at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.lambda$checkOperation$1(ResponseTest.java:107)
        at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.checkOperation(ResponseTest.java:106)
        at com.linkedin.kafka.cruisecontrol.servlet.response.ResponseTest.checkOpenAPISpec(ResponseTest.java:95)

...e-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/GoalViolationDetector.java Outdated Show resolved Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/Provisioner.java Outdated Show resolved Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerState.java Outdated Show resolved Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerState.java Outdated Show resolved Hide resolved
cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerState.java Outdated Show resolved Hide resolved
...se-control/src/test/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerStateTest.java Outdated Show resolved Hide resolved
...se-control/src/test/java/com/linkedin/kafka/cruisecontrol/detector/ProvisionerStateTest.java Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
docs/wiki/User Guide/REST-APIs.md Outdated Show resolved Hide resolved
@kaitlynp1206 kaitlynp1206 mentioned this pull request Aug 12, 2021
Closed
@kaitlynp1206
Create a provisioner state for provision tracking (#4)
a875b17 
Co-authored-by: Kaitlyn Paglia <kpaglia@linkedin.com>
efeg
efeg reviewed Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!
Left more comments.

...ontrol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/parameters/ParameterUtils.java Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
cruise-control/src/yaml/endpoints/rightsize.yaml Outdated Show resolved Hide resolved
docs/wiki/User Guide/REST-APIs.md Outdated Show resolved Hide resolved
docs/wiki/User Guide/REST-APIs.md Outdated Show resolved Hide resolved
docs/wiki/User Guide/REST-APIs.md Outdated Show resolved Hide resolved
@kaitlynp1206 kaitlynp1206 requested a review from efeg August 12, 2021 19:35
efeg
efeg reviewed Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates -- left more comments

cruise-control/src/yaml/responses/rightsizeResult.yaml Outdated Show resolved Hide resolved
...control/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/RightsizeResult.java Show resolved Hide resolved
...control/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/RightsizeResult.java Outdated Show resolved Hide resolved
...ol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/handler/sync/RightsizeRequest.java Outdated Show resolved Hide resolved
...ol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/handler/sync/RightsizeRequest.java Outdated Show resolved Hide resolved
@kaitlynp1206 kaitlynp1206 requested a review from efeg August 12, 2021 22:19
efeg
efeg reviewed Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates -- left a few more comments.

...ol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/handler/sync/RightsizeRequest.java Outdated Show resolved Hide resolved
...ol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/handler/sync/RightsizeRequest.java Outdated Show resolved Hide resolved
...ol/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/handler/sync/RightsizeRequest.java Show resolved Hide resolved
efeg
efeg approved these changes Aug 13, 2021
View reviewed changes
Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaitlynp1206
Thanks for your contribution, which brings Cruise Control a step closer to achieve its vision of fully automated execution of the necessary actions to satisfy SLO requirements while saving time (instantaneous execution), effort (no human intervention), and cost (hardware, VM, and FTEs).

-- LGTM.

@efeg efeg merged commit cf416d4 into linkedin:migrate_to_kafka_2_4 Aug 13, 2021
efeg pushed a commit to efeg/cruise-control that referenced this pull request Aug 13, 2021
@efeg
Setup ProvisionerState for rightsizing clusters (linkedin#1646)
5d77839
efeg pushed a commit to efeg/cruise-control that referenced this pull request Aug 13, 2021
@efeg
Setup ProvisionerState for rightsizing clusters (linkedin#1646)
9957d59
@efeg efeg mentioned this pull request Aug 31, 2021
Closed
zornhsu pushed a commit to zornhsu/cruise-control that referenced this pull request Sep 11, 2021
@zornhsu
Setup ProvisionerState for rightsizing clusters (linkedin#1646)
8581122
@efeg efeg mentioned this pull request Oct 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmr3796 lmr3796 lmr3796 approved these changes

@efeg efeg efeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a ProvisionerState for rightsizing results
3 participants
@kaitlynp1206 @lmr3796 @efeg