Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use literal config name for listeners and broker.id config #2169

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Use literal config name for listeners and broker.id config #2169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...n/java/com/linkedin/kafka/cruisecontrol/metricsreporter/CruiseControlMetricsReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import kafka.server.KafkaConfig;
import org.apache.kafka.clients.ClientUtils;
import org.apache.kafka.clients.CommonClientConfigs;
import org.apache.kafka.clients.admin.AdminClient;
Expand Down Expand Up @@ -126,7 +125,7 @@ public void close() {

static String getBootstrapServers(Map<String, ?> configs) {
Object port = configs.get("port");
String listeners = String.valueOf(configs.get(KafkaConfig.ListenersProp()));
String listeners = String.valueOf(configs.get("listeners"));
if (!"null".equals(listeners) && listeners.length() != 0) {
// See https://kafka.apache.org/documentation/#listeners for possible responses. If multiple listeners are configured, this function
// picks the first listener in the list of listeners. Hence, users of this config must adjust their order accordingly.
Expand Down Expand Up @@ -184,7 +183,7 @@ public void configure(Map<String, ?> configs) {
this.close();
}

_brokerId = Integer.parseInt((String) configs.get(KafkaConfig.BrokerIdProp()));
_brokerId = Integer.parseInt((String) configs.get("broker.id"));

_cruiseControlMetricsTopic = reporterConfig.getString(CruiseControlMetricsReporterConfig.CRUISE_CONTROL_METRICS_TOPIC_CONFIG);
_reportingIntervalMs = reporterConfig.getLong(CruiseControlMetricsReporterConfig.CRUISE_CONTROL_METRICS_REPORTER_INTERVAL_MS_CONFIG);
Expand Down