Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The attributes of the current dataset in the lineage relationship module are not displayed correctly #1827

Closed
cobolbaby opened this issue Aug 27, 2020 · 9 comments
Assignees
Labels
bug Bug report

Comments

@cobolbaby
Copy link
Contributor

2020-08-27 16-27-17屏幕截图

@cobolbaby cobolbaby added the bug Bug report label Aug 27, 2020
@cobolbaby cobolbaby changed the title The attributes of the current data set in the blood relationship module are not displayed correctly The attributes of the current dataset in the lineage relationship module are not displayed correctly Aug 27, 2020
@cptran777
Copy link
Contributor

Hey @cobolbaby , this looks like an issue with accommodating different types being presented by our OS and internal logic and possibly the logic you're currently using. Could you give a sample response of what your current dataset vs upstream vs downstream api looks like? (doesn't have to be any real information included just need a sample structure to debug)

@cobolbaby
Copy link
Contributor Author

@cptran777 Can you give a curl example of how to call the related interface?

@cptran777
Copy link
Contributor

cptran777 commented Aug 28, 2020

@cobolbaby Here's a curl call for upstreams using the fake quickstart data:

curl http://localhost:9001/api/v2/datasets/urn%3Ali%3Adataset%3A%28urn%3Ali%3AdataPlatform%3Ahdfs%2CSampleHdfsDataset%2CPROD%29/upstreams -H "Cookie:<COOKIE INFO HERE"

// Response
[
  {
    "actor": "urn:li:corpuser:jdoe",
    "dataset": {
      "createdTime": null,
      "decommissionTime": 1598684400000,
      "deprecated": true,
      "deprecationNote": "<p>deprecated</p>",
      "description": "",
      "fabric": "PROD",
      "modifiedTime": 1581407189000,
      "nativeName": "SampleKafkaDataset",
      "nativeType": null,
      "platform": "kafka",
      "properties": null,
      "removed": null,
      "tags": [],
      "uri": "urn:li:dataset:(urn:li:dataPlatform:kafka,SampleKafkaDataset,PROD)"
    },
    "modified": null,
    "type": "TRANSFORMED"
  }
]

@cobolbaby
Copy link
Contributor Author

cobolbaby commented Aug 31, 2020

@cptran777

curl -X GET \
  'http://10.191.7.21:9001/api/v2/datasets/urn:li:dataset:%28urn:li:dataPlatform:bdc,dw.fact_cpu_sn,DEV%29/upstreams' \
  -H 'Content-Type: application/json' \
  -H 'Cookie: PLAY_SESSION=6f8d95f03e771c4ba9d24505afff8ef3dafb1ac6-auth_token=ZGF0YWh1YjoxNTk3MDMzNjA4MjUzOjBFNjUwNUVENzk2QjQwNTg5RTM3QkI0MkEyREQ1Nzg0NjkyN0VGRTRGNUFFRDQxMjkwOEU4RDIyNUY4RTk0OEQ%3D&uuid=36dee7c4-d330-46a0-a8da-c4ce5553e955&user=datahub'

[
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.mds_sno",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.mds_sno,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.mds_unit_log",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.mds_unit_log,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.mds_sfc",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.mds_sfc,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.mds_dn",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.mds_dn,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.mds_parts",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.mds_parts,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.cto_sno",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.cto_sno,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.cto_unit_log",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.cto_unit_log,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.cto_sfc",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.cto_sfc,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.cto_dn",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.cto_dn,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    },
    {
        "dataset": {
            "platform": "bdc",
            "nativeName": "fis.cto_parts",
            "fabric": "DEV",
            "uri": "urn:li:dataset:(urn:li:dataPlatform:bdc,fis.cto_parts,DEV)",
            "description": "",
            "nativeType": null,
            "properties": null,
            "tags": [
                "aaa",
                "bbb"
            ],
            "removed": null,
            "deprecated": null,
            "deprecationNote": null,
            "decommissionTime": null,
            "createdTime": null,
            "modifiedTime": 1596614389000
        },
        "type": "TRANSFORMED",
        "actor": "urn:li:corpuser:ITC180016",
        "modified": null
    }
]

curl -X GET \
  'http://10.191.7.21:9001/api/v2/datasets/urn:li:dataset:%28urn:li:dataPlatform:bdc,dw.fact_cpu_sn,DEV%29/downstreams' \
  -H 'Content-Type: application/json' \
  -H 'Cookie: PLAY_SESSION=6f8d95f03e771c4ba9d24505afff8ef3dafb1ac6-auth_token=ZGF0YWh1YjoxNTk3MDMzNjA4MjUzOjBFNjUwNUVENzk2QjQwNTg5RTM3QkI0MkEyREQ1Nzg0NjkyN0VGRTRGNUFFRDQxMjkwOEU4RDIyNUY4RTk0OEQ%3D&uuid=36dee7c4-d330-46a0-a8da-c4ce5553e955&user=datahub' 

[]

@cptran777
Copy link
Contributor

Thanks! I'll start investigating based on the information we have right now.

@cptran777
Copy link
Contributor

Also @cobolbaby thank you for being willing to try out this beta of our new FE and helping discover these bugs/issues. Really appreciate it.

@cptran777
Copy link
Contributor

Hey @cobolbaby, could you pull down the latest changes from #1874 and confirm if the issue is fixed for you?

@frsann
Copy link
Contributor

frsann commented Sep 15, 2020

I had similar problems (in addition the graph visualisation wouldn't render correctly) with the quickstart example + dummy data. I can confirm that this change fixes those issue ✅

@cobolbaby
Copy link
Contributor Author

Confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants