Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gms): use BaseLocalDAO as the interface in factories & rest.li resources #1979

Merged
merged 2 commits into from
Oct 31, 2020
Merged

refactor(gms): use BaseLocalDAO as the interface in factories & rest.li resources #1979

merged 2 commits into from
Oct 31, 2020

Conversation

mars-lan
Copy link
Contributor

Fixes #1974

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@mars-lan mars-lan added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2020
nagarjunakanamarlapudi
nagarjunakanamarlapudi approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@nagarjunakanamarlapudi nagarjunakanamarlapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mars-lan mars-lan merged commit ab03a4e into datahub-project:master Oct 31, 2020
@mars-lan mars-lan deleted the factory branch October 31, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagarjunakanamarlapudi nagarjunakanamarlapudi nagarjunakanamarlapudi approved these changes

@jplaisted jplaisted Awaiting requested review from jplaisted

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EbeanLocalDAO vs BaseLocalDAO
2 participants
@mars-lan @nagarjunakanamarlapudi