Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): update avatar to use initial if no image, refactor all avatars with custom one #2379

Merged
merged 3 commits into from
Apr 9, 2021
Merged

feat(react): update avatar to use initial if no image, refactor all avatars with custom one #2379

merged 3 commits into from
Apr 9, 2021

Conversation

topwebtek7
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

image

@jjoyce0510
Copy link
Collaborator

jjoyce0510 commented Apr 9, 2021 •
edited
Loading

Awesome! Would be great if we could deterministically color them based on character also :)

shirshanka
shirshanka approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit fefcdd9 into datahub-project:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topwebtek7 @jjoyce0510 @shirshanka