Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): isolate dependency requirements of airflow hooks #2977

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix(ingestion): isolate dependency requirements of airflow hooks #2977

merged 1 commit into from
Jul 28, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jul 28, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

kevinhu
kevinhu approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@kevinhu kevinhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For future reference, we may want to add some clarifying comments (e.g. under if TYPE_CHECKING: and make_emitter()) to explain why these imports are conditional.

shirshanka
shirshanka approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 14bca4c into datahub-project:master Jul 28, 2021
@hsheth2 hsheth2 deleted the airflow-dep-localize branch November 10, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@kevinhu kevinhu kevinhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @kevinhu