Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fixing support for kafka key schemas when only key schemas are present #3379

Merged
merged 2 commits into from
Oct 13, 2021
Merged

fix(ingest): fixing support for kafka key schemas when only key schemas are present #3379

merged 2 commits into from
Oct 13, 2021

Conversation

swaroopjagadish
Copy link
Contributor

Also fixed up golden mce-s and added tests for different variants
Thanks to @gabe-lyons for the assist on the UI.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
We'll have to fix the metadata-io test issues in a separate PR.

@shirshanka shirshanka merged commit 146e79b into datahub-project:master Oct 13, 2021
@EnricoMi
Copy link
Contributor

@swaroopjagadish does this revert #3358 on purpose?

https://github.com/linkedin/datahub/pull/3379/files#diff-e3c0d1e22411d7ad903ff6cef9c18f2bf5e744efeec2122b2e5484e12e25e8b5

@EnricoMi EnricoMi mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swaroopjagadish @EnricoMi @shirshanka