Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Snappy Lib and JKS File #3898

Merged
merged 8 commits into from
Jan 21, 2022

Conversation

arunvasudevan
Copy link
Collaborator

@arunvasudevan arunvasudevan commented Jan 16, 2022

Checklist

Issue 1:
Running GMS on Kubernetes cluster causes MCL Consumer thread to stop because of Snappy lib loading issue.

Here is the Error Stack:

[generic-mae-consumer-job-client-0-C-1] ERROR o.s.k.l.KafkaMessageListenerContainer$ListenerConsumer - Stopping container due to an Error
java.lang.UnsatisfiedLinkError: /tmp/snappy-1.1.7-ab3ffedb-1d79-4f1f-8fe3-aa9f8c65c08f-libsnappyjava.so: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /tmp/snappy-1.1.7-ab3ffedb-1d79-4f1f-8fe3-aa9f8c65c08f-libsnappyjava.so)

Looks like this issue is also common - https://stackoverflow.com/questions/50288034/unsatisfiedlinkerror-tmp-snappy-1-1-4-libsnappyjava-so-error-loading-shared-li

Added gcompat lib to solve the issue

Issue 2:

As part of this PR IAM Auth Jar is added to the class path and the following config
SPRING_KAFKA_PROPERTIES_SSL_TRUSTSTORE_LOCATION=/tmp/kafka.client.truststore.jks
expects a jks config file to be available in the above location.

In order to make this truststore file available copying it from openjdk11 cacerts.

Making this change available for all 3 consumers (GMS/MCE/MAE)

@arunvasudevan arunvasudevan mentioned this pull request Jan 16, 2022
@github-actions
Copy link

github-actions bot commented Jan 16, 2022

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   10m 52s ⏱️ - 2m 55s
503 tests ±0  447 ✔️ ±0  56 💤 ±0  0 ±0 

Results for commit 09bb431. ± Comparison against base commit 4b05dcb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this line to mae/mce consumer dockerfiles? to keep them consistent

@arunvasudevan
Copy link
Collaborator Author

@dexter-mh-lee Pushed the update for MAE/MCE Docker scripts as well

@arunvasudevan arunvasudevan changed the title Adding Snappy Lib Adding Snappy Lib and JKS File Jan 18, 2022
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arunvasudevan
Copy link
Collaborator Author

Rebased with master to trigger the tests again

@arunvasudevan
Copy link
Collaborator Author

It looks like the shared lib file (ld-linux-x86-64.so.2) is already present in MAE/MCE. Only missing in GMS.

@arunvasudevan
Copy link
Collaborator Author

Thanks to @dexter-mh-lee for the background.
As part of this PR base image is changed from adoptopenjdk/openjdk8:alpine-jre to alpine:3.14.2 for GMS.
Because of this base-image change gcompat library which is necessary for Snappy library loading is not available in GMS Docker image.

As of now MAE/MCE is still in the base-image adoptopenjdk/openjdk8:alpine-jre so this library is already available part of this image. Once the initiative for change to M1 processors also makes changes to MAE/MCE docker scripts and changes the base-image then this snappy library change also needs to be part of it.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 6990cc5 into datahub-project:master Jan 21, 2022
@arunvasudevan arunvasudevan deleted the docker_updates branch March 4, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants