Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) - move book logo to right of glossary term #4125

Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix(ui) - move book logo to right of glossary term #4125

merged 2 commits into from
Feb 11, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

Search Filter

Before
image

After
image

Tag Term Group

Before
image

After
image

Top Glossary Terms

Before
image

After
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   11m 46s ⏱️ -58s
609 tests ±0  550 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit c83ee96. ± Comparison against base commit 7fcc71e.

gabe-lyons
gabe-lyons approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

shirshanka
shirshanka approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 368b208 into datahub-project:master Feb 11, 2022
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
@ne1r0n
fix(ui) - move book logo to right of glossary term (datahub-project#4125
c362eec 
)

* fix(ui) - move book logo to right of glossary term

* Flip book on top glossary terms
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
@hevandro-veiga
fix(ui) - move book logo to right of glossary term (datahub-project#4125
363ade8 
)

* fix(ui) - move book logo to right of glossary term

* Flip book on top glossary terms
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
fix(ui) - move book logo to right of glossary term (datahub-project#4125
feaf7f7 
)

* fix(ui) - move book logo to right of glossary term

* Flip book on top glossary terms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-radhakrishnan @shirshanka @gabe-lyons