Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Gradle 5 #131

Closed
Mygod opened this issue Dec 19, 2018 · 9 comments
Closed

Incompatible with Gradle 5 #131

Mygod opened this issue Dec 19, 2018 · 9 comments

Comments

@Mygod
Copy link

Mygod commented Dec 19, 2018

Errs: Unresolved reference: ProxyBuilder.

Example build: https://circleci.com/gh/Mygod/VPNHotspot/89

@Mygod
Copy link
Author

Mygod commented Jan 3, 2019

Still present on Gradle 5.1.

@drewhannay
Copy link
Contributor

I'm not clear how this could be an issue with Gradle 5. We're using Gradle 5.0 + dexmaker-mockito and not seeing any issues. Any other information you can provide?

@Mygod
Copy link
Author

Mygod commented Jan 3, 2019

That's weird. You can find source code here and see my example build. It errs on ProxyBuilder not found. And going back to 4.10.2 fixes this. I have no idea why that is.

@Mygod
Copy link
Author

Mygod commented Jan 15, 2019

Still present on 5.1.1.

@Mygod
Copy link
Author

Mygod commented Jan 15, 2019

You can checkout the source code here and see what's wrong: https://github.com/Mygod/VPNHotspot

@hongbinh
Copy link

@Mygod , I downloaded your code and saw the issue, but I believe it's more related to how your project is setup, I'd suggest you check out this gradle doc and see whether anything can give you a clue: https://docs.gradle.org/5.0/userguide/upgrading_version_4.html#changes_5.0

@hongbinh
Copy link

hongbinh commented Jan 17, 2019

@Mygod , adding below line to your build.gradle in "mobile" module should solve your problem:
implementation 'com.linkedin.dexmaker:dexmaker:2.19.1'

@drewhannay
Copy link
Contributor

I think that's probably the right solution. I don't think dexmaker-mockito intends to expose dexmaker as part of its public API. Adding the dependency explicitly seems like a good option here.

@Mygod
Copy link
Author

Mygod commented Jan 18, 2019

Replacing dexmaker-mockito with dexmaker fixes this. Nice! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants