Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Spark fetcher #149

Closed
wants to merge 19 commits into from

Conversation

rayortigas
Copy link
Contributor

While preparing to try improving how Dr. E collects Spark data, I went through some of the existing Spark-related code and tried to clean it up:

  • adding unit tests
  • re-organizing code
  • pruning code
  • closing open connections

Let me know if you have any questions...

@akshayrai
Copy link
Contributor

@rayortigas, could you take care of the Travis build checks? We want Dr. Elephant to work with java 6 also.

@rayortigas
Copy link
Contributor Author

Thanks for the note @akshayrai. I didn't get any messages about the CI failures; can you enable notifications if they aren't already enabled?

Just curious, why do we want to preserve compatibility with Java 6?

@rayortigas
Copy link
Contributor Author

OK, it looks like CI passed this time. Please let me know if you have any other questions.

@akshayrai
Copy link
Contributor

@rayortigas, thanks for fixing it. We have been preserving java 6 just to ensure that people who are still running java 6 on their clusters can use Dr. Elephant.

@akshayrai
Copy link
Contributor

+1, LGTM.

@rayortigas, before we merge, can you fix the small conflict.

@shankar37
Copy link
Contributor

+1

@rayortigas
Copy link
Contributor Author

Closing, now that #162 replaces the old Spark fetcher entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants