BUGFIX Updating AnalyticJobGeneratorHadoop2.java to resolve the Job listing Conflict #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkhrgpt
reviewed
Oct 27, 2017
| @@ -198,7 +198,7 @@ private void updateAuthToken() { | |||
| */ | |||
| private JsonNode readJsonNode(URL url) | |||
| throws IOException, AuthenticationException { | |||
| HttpURLConnection conn = _authenticatedURL.openConnection(url, _token); | |||
| // HttpURLConnection conn = _authenticatedURL.openConnection(url, _token); | |||
| return _objectMapper.readTree(conn.getInputStream()); | |||
There was a problem hiding this comment.
Yes its done. Have sent a second commit.
| @@ -198,7 +198,7 @@ private void updateAuthToken() { | |||
| */ | |||
| private JsonNode readJsonNode(URL url) | |||
| throws IOException, AuthenticationException { | |||
| HttpURLConnection conn = _authenticatedURL.openConnection(url, _token); | |||
| // HttpURLConnection conn = _authenticatedURL.openConnection(url, _token); | |||
There was a problem hiding this comment.
Would this work fine for Kerberos enabled cluster?
There was a problem hiding this comment.
Yes it works. Its being used on a Kerberos enabled Production Cluster
shahrukhkhan489
changed the title
shkhrgpt
reviewed
Oct 28, 2017
| @@ -198,8 +198,8 @@ private void updateAuthToken() { | |||
| */ | |||
| private JsonNode readJsonNode(URL url) | |||
| throws IOException, AuthenticationException { | |||
| HttpURLConnection conn = _authenticatedURL.openConnection(url, _token); | |||
| return _objectMapper.readTree(conn.getInputStream()); | |||
| // HttpURLConnection conn = _authenticatedURL.openConnection(url, _token); | |||
There was a problem hiding this comment.
I think you can just remove this line.
|
@akshayrai If you are satisfied with this change then we should merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating AnalyticJobGeneratorHadoop2.java to resolve the Job listing Conflict as per #301
Issues was raised earlier on https://groups.google.com/forum/#!topic/dr-elephant-users/JeIfb-eiT7w