Removing blocking keyword #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where is the change to make the request.get async and add callback ? Dont they need to go together ? |
|
Not necessarily, the removal of "blocking" keyword would only ensure that infinitely large number of threads are not spawned if some threads are blocked. |
|
+1, I hope you have removed all occurrences of blocking. |
|
Yupp, removed now. |
akshayrai
approved these changes
Apr 6, 2018
pralabhkumar
pushed a commit
to pralabhkumar/dr-elephant
that referenced
this pull request
Aug 31, 2018
Removing blocking keyword to ensure that a large number of threads are not created if some of the threads are blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing blocking keyword to ensure that a large number of threads are not created if some of the threads are blocked.