-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIHADOOP-19841: Enable Analyzing Spark jobs for Namenode HA #55
Conversation
@@ -71,7 +81,8 @@ class SparkFSFetcher(fetcherConfData: FetcherConfigurationData) extends Elephant | |||
*/ | |||
private lazy val _logDir: String = { | |||
val conf = new Configuration() | |||
val nodeAddress = conf.get("dfs.namenode.http-address", null) | |||
val nodeAddress = getNamenodeAddress(conf); | |||
//val nodeAddress = conf.get("dfs.namenode.http-address", null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code
+1 |
if (nameNodeIdentifier != null) { | ||
// there can be multiple namenode identifiers separated by ',' | ||
for (nameNodeidentifierValue <- nameNodeIdentifier.split(",")) { | ||
val httpValue = conf.get(DFS_NAMENODE_HTTP_ADDRESS + "." + nameService + "." + nameNodeidentifierValue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for naming conventions, nameNodeidentifierValue should be nameNodeIdentifierValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Looks good |
@stiga-huang: Thanks for reviewing the code. I've updated the PR after addressing your comments. |
No description provided.