Closes #29. Support specifying node labels for the DataNode and NameNode containers. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverhu
reviewed
Apr 16, 2018
| @@ -328,7 +328,7 @@ public Boolean get() { | |||
| amOptions.getDataNodeVirtualCores() + " vcores, "); | |||
| for (int i = 0; i < numTotalDataNodeContainers; ++i) { | |||
| ContainerRequest datanodeAsk = setupContainerAskForRM(amOptions.getDataNodeMemoryMB(), | |||
| amOptions.getDataNodeVirtualCores(), 1); | |||
| amOptions.getDataNodeVirtualCores(), 1, amOptions.getDataNodeNodeLabelExpression()); | |||
There was a problem hiding this comment.
what's the behavior if this is empty ?
There was a problem hiding this comment.
The default is "", so it uses the default (unlabeled) node label.
…nd NameNode containers.
xkrogen
force-pushed
the
ekrogen-nodelabel-support
branch
from
bc41716
to
2e6f08a
Compare
oliverhu
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.