Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify additional dependencies for containers #73

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

xkrogen
Copy link
Collaborator

@xkrogen xkrogen commented Jan 10, 2019

Currently, the only Java dependency that is distributed to the containers is the dynamometer-infra.jar containing the Application Master. We may need to support arbitrary dependencies in the future, and in particular, Hadoop 3 support will require distributing the JUnit JAR to containers because MiniDFSCluster relies on JUnit. Add in generic support for dependencies, instead of the current method of assuming there is only a single JAR needed.

Copy link
Collaborator

@chliang71 chliang71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xkrogen xkrogen merged commit d71bb96 into linkedin:master Jan 11, 2019
@xkrogen xkrogen deleted the ekrogen-specify-addl-dependencies branch January 11, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants