Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache module discovery #187

Closed
chriseppstein opened this issue Sep 12, 2018 · 1 comment
Closed

Cache module discovery #187

chriseppstein opened this issue Sep 12, 2018 · 1 comment

Comments

@chriseppstein
Copy link
Contributor

There's a bunch of time being wasted by doing repeated module discovery. Because we use require to access package.json files, we can cache module dependency information globally for the duration of the process (and should for consistency). Alternatively, we should not use require and create a different cache context.

#186
@eoneill eoneill mentioned this issue Oct 2, 2018
Merged
eoneill added a commit that referenced this issue Oct 5, 2018
@eoneill
add module discovery caching per #187 (#189)
3c75d33 
* (perf) add module discovery caching
@eoneill
Copy link
Contributor

eoneill commented Oct 30, 2018

resolved with #189

@eoneill eoneill closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriseppstein @eoneill