better support for builds that use symlink #172
Conversation
| // if not... | ||
| if (!canAccess) { | ||
| // check for a symlink... | ||
| var realOrigin = fs.realpathSync(origin); |
There was a problem hiding this comment.
is there a reason not to always realpathSync ? node's resolution algorithm takes that approach.
There was a problem hiding this comment.
This could make a file that is linked to appear like it belongs to a particular module no longer appear as part of the module. It's possible that our validations are being done at the wrong time against the wrong values and that fixing the way those work would be the best solution -- but I think using realpath all the time implies more testing and code changes.
There was a problem hiding this comment.
but I think using realpath all the time implies more testing and code changes.
Makes sense. I suspect this may be something todo, as it (from how I understand eyeglass to work) work more like the node require, and may lead to less surprises when symlinking. it's also possible I don't quite understand this part of eyeglass, and this doesn't make sense.
|
I don't believe this has been released yet, any reason to hold off? |
This issue was discovered while testing with broccoli 1.0. By default, broccoli will now use a global
tmppath rather than local. This means that files get symlink'd in e.g./var/folders/...When eyeglass attempts to do it's module
accesscheck, it walks up the directory tree until it finds apackage.json. It then uses thatpackage.jsonto determine what dependencies can be imported.When these files are symlink'd outside of the project workspace, eyeglass fails to find a
package.jsonand thereby determines the origin scss file does not have access to the requested modules.The fix here is to follow the symlink and check to see if the "real" file has access.
Note that we have to test both the real and symlink paths. We have to test the original symlink path because it's valid to have symlink'd files within a project and they should check access permission relative to the project before following the symlink.
Did not add tests because this is hard to test. Reduced test coverage thresholds a bit as such.