Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option.installWithSymlinks to toggle symlink usage #174

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Add option.installWithSymlinks to toggle symlink usage #174

merged 2 commits into from
Sep 14, 2017

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Sep 1, 2017 •
edited

If enabled, the default assest.install will use symlinks rather then copying.

What this gives us:

  • faster then copying (for those OK with symlinks)
  • "best effort last write wins" makes this as concurrent asset.installs of overlapping files as safe as it can be.

TODO:

  • tests (make all asset.install related tests run both with and without symlinks)
  • update readme ?

@stefanpenner stefanpenner force-pushed the symlink-install branch 4 times, most recently from 2e6e53d to deeb232 Compare September 13, 2017 16:11
@stefanpenner
Add option.installWithSymlinks to toggle symlink usage
13e4f44 
If enabled, the default assest.install will use symlinks rather then copying.
@stefanpenner stefanpenner changed the title Add option.symlinks to toggle symlink usage Add option.installWithSymlinks to toggle symlink usage Sep 13, 2017
@stefanpenner stefanpenner mentioned this pull request Sep 13, 2017
Merged
@stefanpenner stefanpenner merged commit 3241a16 into master Sep 14, 2017
@stefanpenner stefanpenner deleted the symlink-install branch September 14, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoneill eoneill eoneill approved these changes

@chriseppstein chriseppstein Awaiting requested review from chriseppstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanpenner @eoneill