Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize-uri isn’t required in posix, and is quite slow #181

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

stefanpenner
Copy link
Member

No description provided.

@stefanpenner stefanpenner changed the title normalize-uri isn’t required in windows, and is quite slow normalize-uri isn’t required in posix, and is quite slow Apr 4, 2018
@@ -295,7 +295,7 @@ describe("assets", function () {
"$uri: 'assets/foo/bar.png');" +
".test { foo: inspect($eg-registered-assets); }";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this line to .test { foo: inspect(map-get(map-get($eg-registered-assets, module-a), 'foo/bar.png')); } and adjust the output accordingly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¦.test {
  ¦ ¦ -  foo: (module-a: ("foo/bar.png": (filepath: "images/foo/bar.png", uri: "assets/foo/bar.png"))); }
  ¦ ¦ +  foo: (filepath: "images/foo/bar.png", uri: "assets/foo/bar.png"); }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new output looks good, we can set the expected value to that and the tests should pass now, yes?

@stefanpenner
Copy link
Member Author

Without: EyeglassCompiler (33) | 137006ms (4151 ms)
With: EyeglassCompiler (33) | 95998ms (2909 ms)

@chriseppstein
Copy link
Contributor

@eoneill can you review?

@stefanpenner
Copy link
Member Author

eoneill [8:12 AM]
On DTO and limited internet ATM. Looks fine, but can you fix the doc block?

spenner [8:15 AM]
which doc block (sure)

eoneill [8:17 AM]
Looks like the new sass function (eyeglass-normalize-uri) in scss got added under the doc block for the old function
Looks like the new sass function (eyeglass-normalize-uri) in scss got added under the doc block for the old function
Sorry on subway, internet is cutting in and out

spenner [8:18 AM]
ohohoh
i see
yup will fix

eoneill [8:19 AM]
:+1:

@stefanpenner stefanpenner merged commit 680a29b into master Apr 6, 2018
@stefanpenner stefanpenner deleted the make-stuff-faster branch April 6, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants