-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize-uri isn’t required in posix, and is quite slow #181
Conversation
9271b13
to
d13a2e1
Compare
test/test_assets.js
Outdated
@@ -295,7 +295,7 @@ describe("assets", function () { | |||
"$uri: 'assets/foo/bar.png');" + | |||
".test { foo: inspect($eg-registered-assets); }"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this line to .test { foo: inspect(map-get(map-get($eg-registered-assets, module-a), 'foo/bar.png')); }
and adjust the output accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¦.test {
¦ ¦ - foo: (module-a: ("foo/bar.png": (filepath: "images/foo/bar.png", uri: "assets/foo/bar.png"))); }
¦ ¦ + foo: (filepath: "images/foo/bar.png", uri: "assets/foo/bar.png"); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new output looks good, we can set the expected value to that and the tests should pass now, yes?
d13a2e1
to
e6583d9
Compare
Without: |
@eoneill can you review? |
e6583d9
to
d072e88
Compare
|
No description provided.