Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eyeglass] Optimize asset registration #232

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

chriseppstein
Copy link
Contributor

map-merge is slow for maps with many keys. This patch:

  • Changes the asset importer to generate Sass code that invokes @include asset-register-all() instead of many calls to @include asset-register().
  • Changes asset-register-all() to no longer delegate to asset-register() for each asset. Instead it passes all the assets to js where the url normalization is done in a single pass over the asset data structure.
  • On non-windows machines, asset url normalization is completely skipped. This makes asset registration a single map-merge onto a map with low cardinality.

…r a module, and optimize it to avoid map-merge over maps with many keys.
@chriseppstein chriseppstein merged commit 663ebdf into master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant