Add a simple JSON serializer #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: linkedin#167
shotat
force-pushed
the
feature/simple-textual-from-native
branch
from
9e32ac9
to
6e67dbf
Compare
|
@shotat Thanks for this nice PR. I was not aware of this, and added more recently full support for one way handling of json sometime after this PR was posted. I recently completed this by adding full two-way json support in the PR mentioned above. I think this PR will no longer be needed and would like to close this one. |
|
@xmcqueen Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
SimpleTextualFromNativefunction to simplify JSON textual representation.This function allows to yield JSON without type information.
Why
As discussed in following issues, it is needed to serialize JSON without type information in some cases even if it is incompatible with Avro specs.
Fixes #167