Feature/simple data writer #123
Merged
+662
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import gobblin.configuration.ConfigurationKeys; | ||
| import gobblin.configuration.State; | ||
| import gobblin.util.ForkOperatorUtils; |
There was a problem hiding this comment.
There are a number of unnecessary imports.
Add tests Refactor simple data writer Add the final output path to the task properties Update header comment Check return value of this.fs.delete Prepend this. to class variables Add license header Change test port from 8080 to 8000 so we don't have a colision on Jenkins Update LOG class Store the writer output path in a separate key per branch Undo port change for test port Update protobuf extension Style changes and refactors around PR comments Code cleanup with regards to comments on PR Update imports to match style guide Fix import order to match style guide Rename BaseDataWriter to FsDataWriter Add code comment
|
@zliu41 @liyinan926 rebased it all into one commit. This PR is good from my end. Let me know if you guys have any last minute comments. |
|
LGTM. Thanks. |
|
LGTM. |
| } | ||
|
|
||
| // Setting the same HDFS properties as the original file | ||
| WriterUtils.setFileAttributesFromState(properties, fs, outputFile); |
There was a problem hiding this comment.
I just checked in the code that the preservation of file attributes part has been removed.
I just wanted to confirm whether the removal of setFileAttributesFromState was intentional. The changes were made as part of the feature: Support for having file attributes in the State object #131 (#131) If yes, then WriterUtils.setFileAttributesFromState is no longer required. If no, then this needs to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple data writer which writes records as byte[] to a file. This also has some refactors around some of the common elements between writers. Adds a new configuration option to add the writer's final output path to the task properties. This can be used by a publisher to read the write file for a task.