dont ignore i18n object for specific step in tour #170
Conversation
| @@ -756,11 +756,11 @@ | |||
|
|
|||
| // Determine label for next button | |||
| if(isLast){ | |||
| nextBtnText = utils.getI18NString('doneBtn'); | |||
| nextBtnText = (step.i18n && step.i18n["doneBtn"]) || utils.getI18NString('doneBtn'); | |||
There was a problem hiding this comment.
Please use dot syntax here instead of brackets... step.i18n && step.i18n.doneBtn.
(+ other instances)
|
Thanks for the pull request, @nezaidu! It looks like the master branch of your fork has a couple of additional commits unrelated to this pull request that are getting included automatically. Could you create a new branch using the changes in your first commit and push that to your fork on GitHub? Hopefully we can update this PR to point to the new branch, but if not you'll need to create a new PR using the new branch. We should also cover this under our unit tests to ensure we don't have regression on this feature in the future. If you have Grunt (http://gruntjs.com/) already installed locally, you can use |
|
Closing this PR due to inactivity. We'll continue to track this issue on #169 and address this when we clean up how we handle configs in version 0.3.0. |
No description provided.