Patch upstream PR #3717 and its dependencies with some refactor #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and enforce tableName is implemented at compile time (#2630) (cherry picked from commit df93538)
yiqiangin
approved these changes
Jul 18, 2022
| @@ -36,9 +36,18 @@ private TableProperties() { | |||
| public static final String COMMIT_TOTAL_RETRY_TIME_MS = "commit.retry.total-timeout-ms"; | |||
| public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes | |||
|
|
|||
| public static final String COMMIT_NUM_STATUS_CHECKS = "commit.num-status-checks"; | |||
| public static final String COMMIT_NUM_STATUS_CHECKS = "commit.status-check.num-retries"; | |||
There was a problem hiding this comment.
minor: renaming it as something like "COMMIT_NUM_RETRIES_CHECKS", as the value of the string is changed.
There was a problem hiding this comment.
The name is directly from OSS so I feel it's better to keep it aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches apache/iceberg#3717 and its dependencies to make it work in LI-Iceberg 0.11. It will address our production issues where a commit succeeds but its metadata file is deleted (because Iceberg wrongly thinks it fails) and the table is corrupted.
A more detailed explanation could be found in the description of the upstream PR.