Call gevent.monkey.patch_all immediately on import #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api makes use of [gevent], a coroutine based networking library which relies heavily on monkey patching the stdlib. From the [gevent.monkey] docs: > Warning Patching too late can lead to unreliable behaviour > (for example, some modules may still use blocking sockets) or even errors. This appears to have happened here. Thanks to @allwyn-pradip for pointing me at the right file in PR linkedin#690. Resolves linkedin#686, linkedin#699, linkedin#644. Blog on gevent: https://eng.lyft.com/what-the-heck-is-gevent-4e87db98a8 > In the case of gevent — monkey patching has to be the absolute first thing a process does [gevent]: https://www.gevent.org/index.html [gevent.monkey]: https://www.gevent.org/api/gevent.monkey.html
Closed
|
@allwyn-pradip can you confirm if this fixes the issue for you? |
allwyn-pradip
added a commit
to allwyn-pradip/iris
that referenced
this pull request
Apr 12, 2022
Call gevent.monkey.patch_all immediately on import (linkedin#703)
|
@diegocepedaw -- yes it is working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api makes use of gevent, a coroutine based networking library which relies heavily on monkey patching the stdlib.
From the gevent.monkey docs:
This appears to have happened here. Thanks to @allwyn-pradip for pointing me at the right file in PR #690!
Monkey-patching immediately resolves #686, #699, #644.
Blog on gevent: https://eng.lyft.com/what-the-heck-is-gevent-4e87db98a8