User sync removes already existing users

[pavanfhw]

I think this is a misconfiguration on my part, but every loop of the oncall-user-sync it get the users from LDAP server and tries to add them to the database. But if the user already exists it gives the error for each user:
(1062, "Duplicate entry '<my user on ldap server>' for key 'user.username_unique'")

And then the users gets removed from the database (also its contacts etc). The next iteration it inserts all the users present in the LDAP server. Next time it removes them again for the same reason given above. This does not make sense. I am not being able to understand why it is happening. Can someone give correct configuration example for this features?

[altaroinj]

I had the same issue when trying to use oncall.
After investigation, when retrieving users from ldap, username seems to be stored as byte instead of string.
So when users to delete are determined (inactive_users = oncall_usernames - ldap_usernames in ldap_sync.py script), both sets are not in the same format.
To avoid this, I just added this line :
username = username.decode()
just before this one in fetch_ldap() method :
contacts = {'call': mobile, 'sms': mobile, 'email': mail, 'slack': slack, 'name': name}

I am no expert in Python langage, so maybe my solution is not the best, or even breaks something else.
I'll let oncall devs validate it.

[pavanfhw]

Hello @altaroin, thanks for the explanation. I reached the same solution.
My diff in ldap_sync.py is:

-            users[username] = contacts
+            users[username.decode("utf-8")] = contacts

For people with this issue in the future, the issues is caused by the problem explained by @altaroinj. The simple solution is to decode the user like in his (or mine) code example.

[diegocepedaw]

@altaroinj or @pavanfhw, could either of you validate if this change fixes your issue? Internally we use a different custom sync script but I want to make sure the current code is not broken for those that are using the existing ldap sync diegocepedaw@f61fad1

[altaroinj]

@diegocepedaw, I can you confirm that it solved the problem.