[1/5] Set up basic Azure sandbox environment, providers, etc. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumedhsakdeo
requested changes
Jul 12, 2024
There was a problem hiding this comment.
💯 @kmcclenn This is a crisp PR. I left some comments directly in the code for you to accept if you agree with suggestion
infra/recipes/terraform/azure/environments/sandbox/config.azurerm.tfbackend
Outdated
Show resolved
Hide resolved
infra/recipes/terraform/azure/environments/sandbox/variables.tf
Outdated
Show resolved
Hide resolved
infra/recipes/terraform/azure/environments/sandbox/terraform.tfvars
Outdated
Show resolved
Hide resolved
infra/recipes/terraform/azure/environments/sandbox/variables.tf
Outdated
Show resolved
Hide resolved
sumedhsakdeo
requested changes
Jul 12, 2024
sumedhsakdeo
changed the title
sumedhsakdeo
previously approved these changes
Jul 16, 2024
Comment on lines
16
to
17
| ├── provider.tf # Specific variables used for the kubernetes provider configuration | ||
| ├── provider.tf # The global azure and other providers needed for the configurations |
There was a problem hiding this comment.
Suggested change
| ├── provider.tf # Specific variables used for the kubernetes provider configuration | |
| ├── provider.tf # The global azure and other providers needed for the configurations | |
| ├── provider.tf # Specific variables used for the kubernetes provider configuration | |
| ├── provider.tf # The global azure and other providers needed for the configurations |
Two provider.tf ?
There was a problem hiding this comment.
Oops. I will remove one.
Co-authored-by: Sumedh Sakdeo <sumedhsakdeo@gmail.com>
Co-authored-by: Sumedh Sakdeo <sumedhsakdeo@gmail.com>
abhisheknath2011
approved these changes
Jul 17, 2024
sumedhsakdeo
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the basic environment setup for configuration with Azure. Used terraform to add backend, providers, and resource group configuration. Similar to PR #129 but split up into 5 parts.
PR 1: #136 (terraform backend)
PR 2: kmcclenn#3 (VM)
PR 3: kmcclenn#4 (MySQL)
PR 4: kmcclenn#5 (k8s)
PR 5: kmcclenn#6 (Storage Account)
Changes
Testing Done
Ran the commands as specified in the README. All of the services ran, and for confirmation they appeared in my Azure portal.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.