Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convert_datetime_to_utc() test. #22

Closed
wants to merge 1 commit into from
Closed

Fix convert_datetime_to_utc() test. #22

wants to merge 1 commit into from

Conversation

nud
Copy link

@nud nud commented Oct 27, 2014

The test had two flaws:

  1. The actual date was different (4/1 vs 1/1)
  2. The time offset in the test was not correct (UTC-07:00 instead of
    UTC-08:00)

@nud
Fix convert_datetime_to_utc() test.
e981b9d 
The test had two flaws:
 1. The actual date was different (4/1 vs 1/1)
 2. The timezone usage was not correct (using the timezone as an
    argument of the datetime constructors won't work with timezones
    with daylight saving time according to documentation).
@nud nud closed this Oct 27, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e981b9d on nud:fix-tz-test into 3cdb335 on linkedin:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e981b9d on nud:fix-tz-test into 3cdb335 on linkedin:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nud @coveralls