python3 has no unicode builtin

[eddy-geek]

This fixes python3 compatibility (at least for getting events in date range as per the tutorial)

[coveralls]

Coverage decreased (-0.08%) when pulling d126b5d on eddy-geek:master into b57555d on linkedin:master.

[coveralls]

Coverage decreased (-0.08%) when pulling f8fc2e4 on eddy-geek:master into b57555d on linkedin:master.

[catermelon]

Hey, thanks for the commit! Can you tell me a little more why this was necessary? What broke?

[eddy-geek]

The doc states "PyExchange supports Python 2.6 and 2.7. Our code is compatible with 3.3+, but see the notes below on getting it working."
Besides the fact that the "notes" on ntlm are not valid anymore (pip3 install pyexchange now works out of the box AFAIK), running the this code from the docs under python3 will fail with NameError: name 'unicode' is not defined or similar error.
Maybe this would be more visible if python3 was enabled on Travis C.I./coverage ?

The culprit is in get_calendar_item around line 130

       u'MaxEntriesReturned': unicode(max_entries),

BTW, same issue in exchange2010/init.py in move_to with:

    if not isinstance(folder_id, basestring):

I will fix that one too, probably along with some mail support :-)
Do you prefer separate PRs ?

[catermelon]

Derp, I meant to get back to you and blanked. Sorry for the delay! You're right, let me enable Python 3 support on Travis so I can see what breaks across the board.

[catermelon]

It looks like I had some unmerged code that fixes all this - can you try the most recent commit I just made and see if it works for you? It's passing Travis now for 3.3 and 3.4.

thanks again for the work, I appreciate it.

[eddy-geek]

Not tested yet, but this looks to be removing all the unicode & basestring references that were causing problems. Thanks.
I didn't create the PR from a feature branch so all my new commits are creeping in.

• Do you want to close this one ?
• Should I create a new one ? I have started basic mail support but there are no unit-tests, so not sure if you would want to merge it. Other changes should be self-explanatory.

[catermelon]

If you wouldn't mind starting a new one, that would be fab. And yes, please, I would need some tests before merging it, although I'm happy to look at a preliminary pull request if you want another eye for code review.