Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify_certificate parameter. #45

Merged
merged 1 commit into from Apr 1, 2015
Merged

Conversation

nicklasb
Copy link
Contributor

@nicklasb nicklasb commented Apr 1, 2015

If True, the SSL cert will be verified, if false it will not.
A CA_BUNDLE path can also be provided.

It is just like the request.post works.

I propose this as I don't think it adds much to force verification, except hassle for developers that wants to try out the library.

If True, the SSL cert will be verified, if false it will not.
A CA_BUNDLE path can also be provided.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.41% when pulling 9953649 on OptimalBPM:master into 7f8c181 on linkedin:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.41% when pulling 9953649 on OptimalBPM:master into 7f8c181 on linkedin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.41% when pulling 9953649 on OptimalBPM:master into 7f8c181 on linkedin:master.

@nicklasb
Copy link
Contributor Author

nicklasb commented Apr 1, 2015

Hm. The 3.4 tests time out: https://travis-ci.org/linkedin/pyexchange/jobs/56710016

Actually this happened to me as well when I ran the tests locally using pytest.
It timeouts at some seemingly random test.
If I debug it, the tests doesn't even enter the test function.
I though it was something about my installation, because I that run it using nosetest and then it worked.

But now it rather seems like an issue with pytest and python 3.4

@nicklasb
Copy link
Contributor Author

nicklasb commented Apr 1, 2015

Ok, so I looked at the other pull requests and it seems py.test have timed out under 3.4 on every build since january. There seem to be something generally wrong.
Do with this PR what you want.

@nicklasb
Copy link
Contributor Author

nicklasb commented Apr 1, 2015

I just realized that nosetest also hangs, but much later on. Investigating.

@nicklasb
Copy link
Contributor Author

nicklasb commented Apr 1, 2015

Found nothing. I will create an issue and let those more aquainted to the testing of this project look at it instead.

@got-root
Copy link
Contributor

got-root commented Apr 1, 2015

I've verified that this passes all tests on python 3.4.1 when dropping httpretty to version 0.8.6.

got-root added a commit that referenced this pull request Apr 1, 2015
Add verify_certificate parameter.
@got-root got-root merged commit 9de65b8 into linkedin:master Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants