Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink traversal to support PDM cached envs #237

Merged
merged 2 commits into from Sep 7, 2023

Conversation

f3flight
Copy link
Contributor

@f3flight f3flight commented Sep 7, 2023

Fixes #236

Shiv currently does not collect symlinked directories and files within. This PR makes it do just that, which helps support environments created with PDM with cache=True.

In future this can be solved more elegantly with a builtin flag which will be introduced in Python 3.13 - python/cpython#77609

@lorencarvalho lorencarvalho merged commit e41234b into linkedin:main Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environments created with symlinked folders (by PDM with cache=True) are not correctly packed
2 participants